Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAVADOC-682] Reactor builds fail when multiple modules with same gr… #253

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

michael-o
Copy link
Member

…oupId:artifactId, but different versions

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@ao-apps
Copy link

ao-apps commented Nov 30, 2023

I have created integration tests for MJAVADOC-682: 2f291d4

Should I create a separate pull request, or you can merge this commit into your MJAVADOC-682 branch?

Thank you,

  • Dan

@michael-o
Copy link
Member Author

I have created integration tests for MJAVADOC-682: 2f291d4

Should I create a separate pull request, or you can merge this commit into your MJAVADOC-682 branch?

Thank you,

* Dan

I will intergrate from here: https://github.com/ao-apps/maven-javadoc-plugin/tree/MJAVADOC-682

@ao-apps
Copy link

ao-apps commented Nov 30, 2023

Should I change the commit message to begin with "[MJAVADOC-682]"?

@michael-o
Copy link
Member Author

Should I change the commit message to begin with "[MJAVADOC-682]"?

No, I will squash anyway and give you attributions, of course.

asfgit pushed a commit that referenced this pull request Nov 30, 2023
…oupId:artifactId, but different versions

Co-authored-by: AO Industries, Inc <support@aoindustries.com>

This closes #253
@michael-o
Copy link
Member Author

CI is rolling...

@ao-apps
Copy link

ao-apps commented Nov 30, 2023

CI is rolling...

I just noticed a mistake and force-pushed a fix. I left the "package" declaration on top of the module-info.java files.

…oupId:artifactId, but different versions

Co-authored-by: AO Industries, Inc <support@aoindustries.com>

This closes #253
@michael-o
Copy link
Member Author

CI is rolling...

I just noticed a mistake and force-pushed a fix. I left the "package" declaration on top of the module-info.java files.

Modified...

@ao-apps
Copy link

ao-apps commented Nov 30, 2023

I went ahead and confirmed the provided integration tests for MJAVADOC-682 do, in fact, reproduce the originally reported issue: The build succeeds on 3.0.1 and fails on 3.6.2 as expected.

@michael-o michael-o marked this pull request as ready for review November 30, 2023 21:20
ao-apps added a commit to ao-apps/maven-javadoc-plugin-failing-multiple-projects-same-name that referenced this pull request Nov 30, 2023
for inclusion in version 3.6.3.
@asfgit asfgit merged commit b69af90 into master Nov 30, 2023
51 checks passed
@michael-o michael-o deleted the MJAVADOC-682 branch November 30, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants