Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAR-275] - Fix outputTimestamp not applied to module-info; breaks reproducible builds #43

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

jorsol
Copy link
Contributor

@jorsol jorsol commented Jun 6, 2022

This requires the release of plexus-archiver 4.3.0 and maven-archiver 3.6.0.

Fixing the "MJAR-275 - outputTimestamp not applied to module-info; breaks reproducible builds"

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAR-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAR-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@jorsol jorsol marked this pull request as draft June 6, 2022 12:20
@jorsol jorsol marked this pull request as ready for review June 13, 2022 10:24
@jorsol jorsol force-pushed the MJAR-275 branch 3 times, most recently from 3898d04 to 96395aa Compare June 13, 2022 11:41
@jorsol jorsol force-pushed the MJAR-275 branch 2 times, most recently from c1a4242 to e8c7c8c Compare June 27, 2022 09:29
@jorsol jorsol changed the title [MJAR-275] - Update maven-archiver to 3.6.0 [MJAR-275] - Update Maven Archiver to 3.6.0 Jun 29, 2022
@cstamas
Copy link
Member

cstamas commented Jul 2, 2022

The https://issues.apache.org/jira/browse/MJAR-278 PR #19 merged, please rebase and continue along it @jorsol

@jorsol jorsol changed the title [MJAR-275] - Update Maven Archiver to 3.6.0 [MJAR-275] - Fix outputTimestamp not applied to module-info; breaks reproducible builds Jul 2, 2022
…eproducible builds

Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
@jorsol
Copy link
Contributor Author

jorsol commented Jul 2, 2022

Rebased, please continue with the review, thanks!

@slawekjaranowski slawekjaranowski merged commit 46c017d into apache:master Jul 4, 2022
@jorsol jorsol deleted the MJAR-275 branch July 4, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants