Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINDEXER-176] Clean up silos #273

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 24, 2022

The MT updater did not clean up silos after done.


https://issues.apache.org/jira/browse/MINDEXER-176

The MT updater did not clean up silos after done.

---

https://issues.apache.org/jira/browse/MINDEXER-176
@cstamas cstamas self-assigned this Nov 24, 2022
@cstamas
Copy link
Member Author

cstamas commented Nov 24, 2022

@mbien pls take a peek

@cstamas cstamas marked this pull request as ready for review November 24, 2022 08:14
@cstamas cstamas requested a review from slachiewicz November 24, 2022 08:14
@cstamas cstamas added this to the 7.0.1 milestone Nov 24, 2022
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks!

and regroup a bit: do not call addIndexes from loop
when it can be batched.
@cstamas cstamas merged commit c2a438a into apache:master Nov 28, 2022
@cstamas cstamas deleted the MINDEXER-176-cleanup-silos branch November 28, 2022 07:22
@mbien
Copy link
Member

mbien commented Feb 18, 2023

@cstamas any chance for an update release till May? I would be particularly interested in this fix here which would make me more comfortable to enable MT index extraction in NetBeans. (if not - no problem, there is always the next release :))

btw love the new formatting!

@cstamas
Copy link
Member Author

cstamas commented Feb 18, 2023

Sure, am a bit distracted with resolver 1.9.5 and maven 3.9.1 but I planned to release this as next (this is NOT FINAL but a DRAFT release notes, just to make sure anon users can access it) https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317523&version=12352530

MINDEXER-183 is still "in progress" #292 , will take a peek at it and merge and then release can happen.

Any hint, opinion, idea (or maybe opposing to any change above), please ping me on ML and let's discuss https://maven.apache.org/mailing-lists.html

(or hop onto ASF Slack)

@cstamas
Copy link
Member Author

cstamas commented Feb 18, 2023

Oh, "upgrade to resolver 1.9.4" is also def to happen (1.9.2 has issues)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants