Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MGPG-135] Support Overriding / Enhance the signer in AbstractGpgMojo #112

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Aug 11, 2024

Currently AbstractGpgMojo has a fixed set of supported signers (and how they are constructed), it would be good to allow extensions (e.g. Tycho is also using AbstractGpgMojo) to possibly override that aspect.

This extracts the creation of the signer into a (protected) method so different types or alternative implementations can be used.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually
    before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should
    address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MGPG-XXX] - Fixes bug in ApproximateQuantiles, where you replace MGPG-XXX
    with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the
    first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull
    request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure please ask on the
developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Currently AbstractGpgMojo has a fixed set of supported signers (and how
they are constructed), it would be good to allow extensions (e.g. Tycho
is also using AbstractGpgMojo) to possibly override that aspect.

This extracts the creation of the signer into a (protected) method so
different types or alternative implementations can be used.
@cstamas cstamas changed the title MGPG-135 - Support Overriding / Enhance the signer in AbstractGpgMojo [MGPG-135] Support Overriding / Enhance the signer in AbstractGpgMojo Aug 14, 2024
@cstamas cstamas merged commit 1b40a05 into apache:master Aug 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants