[MSKINS-169] Image height not effective #23
Conversation
|
@kwin Please review. |
| @@ -253,7 +253,6 @@ under the License. | |||
| <goals> | |||
| <goal>site</goal> | |||
| </goals> | |||
| <streamLogsOnFailures>true</streamLogsOnFailures> | |||
There was a problem hiding this comment.
It spills the terminals with thousands of lines of debug output. Basically impossible to scroll back to the invoker report and pray that your terminal buffer is large enough. Moreover, in other components this isn't enabled also.
There was a problem hiding this comment.
fair enough but the problem is more: why do we have this for m-invoker-p? (as you complain about verbosity :) )
<debug>true</debug>
There was a problem hiding this comment.
I can't tell whether this is enabled for other components as well, but the build.log will contain debug output which is very helpful in failure cases. If it is not enabled, you need to enable it temporarily and and run everything again. Just losing time.
|
@kwin any change you can verify this in time? |
| @@ -110,21 +110,21 @@ | |||
| #* *##set ( $imgAlt = ' alt=""' ) | |||
| #* *##end | |||
| #* *##if( $border ) | |||
| #* *##set ( $imgBorder = ' border="' + $border + '"' ) | |||
| #* *##set ( $imgBorder = 'border: ' + $border + ';' ) | |||
There was a problem hiding this comment.
This should be rather border-width (https://developer.mozilla.org/en-US/docs/Web/CSS/border-width) as the css attribute border may also set other styles and may lead to some ambiguity and border-width is the equivalent of the border html attribute. The spec is not really clear in this regard though: https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerLeft
There was a problem hiding this comment.
I agree this needs clarification or change, but that will happen in Doxia 2 only.
There was a problem hiding this comment.
Raise an issue with Doxia Sitetools.
There was a problem hiding this comment.
It is also imperative to provide units otherwise the browser will ignore them. Reason for the failure: https://stackoverflow.com/a/44010892/696632 This closes #23
It is also imperative to provide units otherwise the browser will ignore them. Reason for the failure: https://stackoverflow.com/a/44010892/696632 This closes #23
It is also imperative to provide units otherwise the browser will ignore
them.
Reason for the failure: https://stackoverflow.com/a/44010892/696632
This closes #23