Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSKINS-167] Add deep anchors to headers #19

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Conversation

dialaya
Copy link
Contributor

@dialaya dialaya commented May 29, 2020

As a rework to add anchors to sections header using AnchorJS utility as
the site
resources instead of loading from the Internet.

This closes #167

As a rework to add anchors to sections header using AnchorJS utility as
the site
resources instead of loading from the Internet.

This closes #167
@dialaya
Copy link
Contributor Author

dialaya commented May 29, 2020

As see with @hboutemy we would like to rollback changes made in anchor js lib.
Therefore rework to keep the lib as it is from cdn after switching to CLOSURE engine.

@hboutemy hboutemy merged commit 6878585 into apache:master Jun 6, 2020
@hboutemy
Copy link
Member

hboutemy commented Jun 6, 2020

nice work done, thank you @dialaya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants