[MSKINS-168] Switch Minification Engine from YUI to CLOSURE

[dialaya]

YUI compressor engine seems not support ES5 syntaxes.
Js compilation fails when using new javascript libraries with ES5 syntax.

Switch to CLOSURE engine to bypass the issues.

Closes #168

[dialaya]

Hi @hboutemy ,
Could you please have a look at the failed check and review the pull request ?

Regards,

[michael-o]

Which new files did you try to fail the build?

[dialaya]

@michael-o What I know is that the job-14 failed during call of ExtractToDirectory.
The change I have made only specify a jscompressor engine.

Thank you.

[michael-o]

I did not refer to CI, but to specific JS files you have tried.

[dialaya]

below target JS libs are affected:

• anchorjs
• bootstrap 4
• jquery 3
• or any other new lib that uses ES5 or greater you might need to use later

Without the switch: i made changes in anchorjs lib that you can see in my previous pull request #17 that I had aborted to avoid custom maintenance.

But for jquery and bootstrap I is not a good idea to modify the syntax because of ES5 support issues.

Please see MSKINS-168 for more details.

[michael-o]

Thanks, that's what I wanted to know.

[hboutemy]

nice change, well explained: thank you @dialaya

[dialaya]

Thank you