[MSKINS-167] Add deep anchors to headers #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add anchors to sections header using AnchorJS utility. The Permalink icon is displayed on Mouse-Over. This helps on sharing links. This closes #167
|
thank you @dialaya , that's really an awesome improvement |
|
This should have been distributed with the site resources and not loaded from the Internet. Just like we do with Bootstrap and other resources. |
|
@dialaya can you have a look please to host the lib in the skin instead of using CDN, please? |
|
@dialaya FYI, I just upgraded the skin used by Maven site itself, the result is great https://maven.apache.org/ :) |
|
Hi,
Yes I can do.
I will do.
Thank you.
Regards,
Le lun. 20 avr. 2020 à 00:44, Hervé Boutemy <notifications@github.com> a
écrit :
… @dialaya <https://github.com/dialaya> can you have a look please to host
the lib in the skin instead of using CDN, please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB6HI7AZUVMZPHXPWXUGNDRNN5EZANCNFSM4MH64K4Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull add a use of AnchorJS utility to generate deep anchors to sections header
The Permalink icon is displayed on Mouse-Over.
This helps on sharing links.
This closes #167