Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOXIASITETOOLS-311] Rework and simplify the site model #110

Merged
merged 1 commit into from
Oct 1, 2023
Merged

[DOXIASITETOOLS-311] Rework and simplify the site model #110

merged 1 commit into from
Oct 1, 2023

Conversation

michael-o
Copy link
Member

No description provided.

@michael-o michael-o changed the title first shot Doxia Site Model Rework Jun 24, 2023
@hboutemy
Copy link
Member

IIUC, the proposal is (in addition to renaming project to site):

  1. introduction of this <image src=... alt=... style=... .../> element to match HTML's <img src=... .../>
  2. uniform use of this <image> element in <bannerLeft>, <bannerRight>, <item> and <logo> with name and href as attributes

looks very smart: simple and powerful

hboutemy
hboutemy approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, just need to associate the commit to a Jira issue (critical for future references)

asfgit pushed a commit that referenced this pull request Aug 26, 2023
@michael-o
[DOXIASITETOOLS-311] Rework and simplify the site model
d909313 
This closes #110
@michael-o michael-o changed the title Doxia Site Model Rework [DOXIASITETOOLS-311] Rework and simplify the site model Aug 26, 2023
@michael-o
Copy link
Member Author

very good, just need to associate the commit to a Jira issue (critical for future references)

Done

asfgit pushed a commit that referenced this pull request Sep 23, 2023
@michael-o
[DOXIASITETOOLS-311] Rework and simplify the site model
073afea 
This closes #110
@michael-o michael-o marked this pull request as ready for review October 1, 2023 13:05
asfgit pushed a commit that referenced this pull request Oct 1, 2023
@michael-o
[DOXIASITETOOLS-311] Rework and simplify the site model
664473e 
This closes #110
@asfgit asfgit closed this in afcd656 Oct 1, 2023
@asfgit asfgit merged commit afcd656 into master Oct 1, 2023
3 of 4 checks passed
@michael-o michael-o deleted the site-model-rework branch October 1, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboutemy hboutemy hboutemy approved these changes

@bmarwell bmarwell Awaiting requested review from bmarwell

@kwin kwin Awaiting requested review from kwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-o @hboutemy @asfgit