Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDEPLOY-255] altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/c… #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vtitov
Copy link

@vtitov vtitov commented Apr 3, 2019

MDEPLOY-255 altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/cygwin on windows

Following this checklist to help us incorporate your
contribution quickly and easily:

  • [x ] Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • [x ] Each commit in the pull request should have a meaningful subject line and body.
  • [ x] Format the pull request title like [MPH-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MPH-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • [ x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ x] Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@vtitov vtitov force-pushed the bugfix/mingw-url branch from f4f362d to e22c05c Compare April 8, 2019 10:39
@vtitov vtitov changed the title altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/c… [MDEPLOY-255] altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/c… Apr 8, 2019
@vtitov vtitov marked this pull request as ready for review April 8, 2019 10:41
@michael-o
Copy link
Member

michael-o commented Apr 10, 2019

I consider this to be a workaround rather than a solution because the root cause has not been found.

Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up this issue

Is this pr a draft?
I can't see a relation with the problem

We should also add some test

@vtitov
Copy link
Author

vtitov commented Apr 18, 2019

@michael-o, @eolivelli,

For me it is indeed w/a, which lets me modify, compile and deploy some stuff from github to internal repo to debug the project I'm working on.
I consider it as a draft because I'm not sure it's me who have to decide if deploy plugin should get a couple (or three couples) of new parameters or there is another w/a.
I suppose the problem might be related to org.apache.maven.shared.transfer.project.deploy.ProjectDeployerRequest from maven-artifact-transfer, but I considered as overkill for me to debug this project.
he problem itself might be in incorrect storing/parsing colons and URL part of altDeploymentRepository parameter in mingw environment, because cygwin/mings might make attempts to convert unix/windows path separators:

  • ':'<->';'
  • '/'<->'\'
    When I pass repo id as text and url as URL plugin works fine.
    I'm not sure I'm ready for writing tests right now.

@vtitov vtitov closed this Apr 18, 2019
@vtitov vtitov reopened this Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants