Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more jdk for testing #93

Merged
merged 5 commits into from
Feb 9, 2022
Merged

add more jdk for testing #93

merged 5 commits into from
Feb 9, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented Feb 9, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy olamy added the build label Feb 9, 2022
Copy link
Contributor

@hisener hisener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:allthethings:

(Yes, I am looking forward to the 3.10.0 release!)

@slawekjaranowski
Copy link
Member

slawekjaranowski commented Feb 9, 2022

If you want add microsoft for other then jdk 8 you can try add:

matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"}]'

@@ -26,4 +26,4 @@ jobs:
name: Verify
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
with:
jdk-distribution-matrix: '[ "temurin", "zulu" ]'
jdk-distribution-matrix: '[ "temurin", "zulu", "adopt", "liberica", "microsoft" ]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adopt is deprecated, we should use only temurin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Azure now deprecating support for Azul and recommends switching to own distribution

@olamy olamy merged commit 500ade4 into master Feb 9, 2022
@olamy olamy deleted the gh-action-more-jdk branch February 9, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants