Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) Fixes in multirelease page #26

Merged
merged 12 commits into from
Feb 29, 2020
Merged

(doc) Fixes in multirelease page #26

merged 12 commits into from
Feb 29, 2020

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Dec 9, 2019

  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    (Previous faillure due to missing env var JAVA_HOME expected in

    setVariableValueToObject( compileMojo, "executable", new File( System.getenv( "JAVA_HOME" ), "bin/javac" ).getPath() );
    )
    I also ran mvn site -DskipTests=true to observe my changes in produced target/site/multirelease.html.

  • You have run the integration tests successfully (mvn -Prun-its clean verify).


To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

@pzygielo pzygielo requested a review from rfscholte January 17, 2020 21:07
@pzygielo
Copy link
Contributor Author

pzygielo commented Jan 17, 2020

Changes without line splitting commits: master...41e3afb

@rfscholte rfscholte merged commit 0285c62 into apache:master Feb 29, 2020
@pzygielo pzygielo deleted the doc branch February 29, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants