[MCOMPILER-523] Test with Maven 3.9.0 and fix the failing IT #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiroky
reviewed
Feb 10, 2023
.github/workflows/maven-verify.yml
Outdated
| @@ -30,4 +30,4 @@ jobs: | |||
| jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "adopt-openj9" ]' | |||
| jdk-matrix: '[ "8", "11", "17", "18" ]' # "19-ea" | |||
| matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"},{ "jdk": "19-ea", "distribution": "microsoft"},{ "jdk": "18", "distribution": "microsoft"},{ "jdk": "19-ea", "distribution": "adopt-openj9"},]' | |||
| maven-matrix: '[ "3.3.9", "3.6.3", "3.8.6" ]' # Maven versions matrix for verify builds | |||
| maven-matrix: '[ "3.3.9", "3.6.3", "3.8.6", "3.9.0", "4.0.0-alpha-4" ]' # Maven versions matrix for verify builds | |||
There was a problem hiding this comment.
Not directly related to this commit (sorry for intruding):
- Should we also build with JDK 19 rather than 18? E.g. use the latest stable JDK?
- And maybe build with 3.8.7 instead of 3.8.6?
There was a problem hiding this comment.
maybe get rid of 3.6.3?
and agree on removing 18 and replace with 19 (maybe 20-ea if exists?)
There was a problem hiding this comment.
Yes, I think we should test LTS versions + latest.
I'll use this PR to fix the failing IT too.
There was a problem hiding this comment.
Though changing the supported JDK may require some additional matrix exclusions, so we may want to tackle that in a different PR, I'll focus on maven versions + fixing the IT for now.
gnodet
changed the title
|
Looks good to me ( I can't of course formally approve or so). |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MCOMPILER-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.