-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MCOMPILER-395] Allow dependency exclusions for 'annotationProcessorPaths' #173
Conversation
src/main/java/org/apache/maven/plugin/compiler/DependencyCoordinate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/plugin/compiler/DependencyExclusion.java
Outdated
Show resolved
Hide resolved
7579cfa
to
89a1845
Compare
@slawekjaranowski @cstamas hello again! Would you guys have some time to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update documentation of annotationProcessorPaths
parameter.
89a1845
to
0ee74f2
Compare
@slawekjaranowski thanks, Javadoc updated (I hope this is what you meant by documentation). The rendered page now looks like this: |
...ion-verify-plugin/src/main/java/org.apache.maven.plugins.compiler.it/SourcePathReadGoal.java
Outdated
Show resolved
Hide resolved
0ee74f2
to
804def4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
804def4
to
5a041ce
Compare
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MCOMPILER-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.