Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-395] Allow dependency exclusions for 'annotationProcessorPaths' #173

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

psiroky
Copy link
Contributor

@psiroky psiroky commented Jan 30, 2023

  • this should be quite straightforward to review, since the plugin only needs to "push" the exclusions down to the maven-resolver and all the "magic" happens there

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@psiroky psiroky changed the title [MCOMPILER-395] Support exclusions for 'annotationProcessorPaths' [MCOMPILER-395] Allow dependency exclusions for 'annotationProcessorPaths' Feb 1, 2023
@psiroky
Copy link
Contributor Author

psiroky commented Feb 1, 2023

@slawekjaranowski @cstamas hello again! Would you guys have some time to review this PR?

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update documentation of annotationProcessorPaths parameter.

@psiroky
Copy link
Contributor Author

psiroky commented Feb 1, 2023

@slawekjaranowski thanks, Javadoc updated (I hope this is what you meant by documentation). The rendered page now looks like this:
compiler-plugin-path-exclusions

@psiroky

This comment was marked as outdated.

@gnodet gnodet added this to the 3.11.0 milestone Feb 13, 2023
@gnodet gnodet merged commit 86b9f59 into apache:master Feb 13, 2023
@psiroky psiroky deleted the MCOMPILER-395 branch February 13, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants