[MCLEAN-126] Replaced old File API with new Path equivalent where possible #62
+77
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdemaeyer
force-pushed
the
MCLEAN-126
branch
from
632366f to
7754dd7
Compare
peterdemaeyer
force-pushed
the
MCLEAN-126
branch
from
7754dd7 to
99b4b8d
Compare
elharo
reviewed
Nov 14, 2024
| @@ -197,7 +199,7 @@ public class CleanMojo extends AbstractMojo { | |||
| * waiting for all files to be deleted when the session ends, <code>at-end</code> to indicate that the actual | |||
| * deletion should be performed synchronously when the session ends, or <code>defer</code> to specify that | |||
| * the actual file deletion should be started in the background when the session ends (this should only be used | |||
There was a problem hiding this comment.
session ends. (This should only be used
| @@ -197,7 +199,7 @@ public class CleanMojo extends AbstractMojo { | |||
| * waiting for all files to be deleted when the session ends, <code>at-end</code> to indicate that the actual | |||
| * deletion should be performed synchronously when the session ends, or <code>defer</code> to specify that | |||
| * the actual file deletion should be started in the background when the session ends (this should only be used | |||
| * when maven is embedded in a long running process). | |||
| * when maven is embedded in a long-running process). | |||
There was a problem hiding this comment.
I see your point. Maybe even drop the parentheses altogether?
slachiewicz
approved these changes
Dec 8, 2024
slawekjaranowski
approved these changes
Dec 8, 2024
|
Resolve #168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced usage of old
FileAPI with newPathAPI where possible.