-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARCHETYPE-574] Use default values in integration tests goal #232
[ARCHETYPE-574] Use default values in integration tests goal #232
Conversation
@slawekjaranowski I'm not sure if you are the right person to ask, but I see you have been working on the plugin recently. What do you think of the change regarding the integration tests (see description of this PR)?
|
...lugin/src/it/projects/ARCHETYPE-574_default-value-should-be-used-in-integration-test/pom.xml
Outdated
Show resolved
Hide resolved
...-should-be-used-in-integration-test/src/main/resources/META-INF/maven/archetype-metadata.xml
Outdated
Show resolved
Hide resolved
Still unsure why test fails on agent, but succeeds locally.. |
I will look at it |
0d94fdc
to
12b6612
Compare
generate
goal to provide default values.I had to change some existing integration tests, because apparently it is possible to add non-existing properties to an archetype in the
integration-test
goal, while this is not possible when using thegenerate
goal. I've tried to add non-existing properties through the command line; both with-DsomeProp=test
and through a properties file-Darchetype.properties=./archetype.properties
.In both cases I was unable to include them while generating an archetype, which leads me to believe the integration test adding those properties to the archetype configuration is wrong compared to the actual implementation. It now matches the replacing of properties correctly. Hence the changes in the existing integration tests. WDYT?
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[ARCHETYPE-XXX] SUMMARY
,where you replace
ARCHETYPE-XXX
andSUMMARY
with the appropriate JIRA issue.[ARCHETYPE-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.