Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Replace SetOnce Get/Set with Value, #1069 #1071

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Replaces Get and Set on the SetOnce<T> type with a new Value property, marks old methods as deprecated for removal.

Fixes #1069

Description

In addition to the above, this also enables nullable in the file, and adds more meaningful exceptions in cases where otherwise it could possibly throw a NRE.

@paulirwin paulirwin added the notes:breaking-change Has changes that will break backward compatibility label Dec 21, 2024
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to merge.

@paulirwin paulirwin merged commit e40a520 into apache:master Dec 21, 2024
267 checks passed
@paulirwin paulirwin deleted the issue/1069 branch December 21, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:breaking-change Has changes that will break backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Refactor SetOnce<T> to .NETify
2 participants