Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWEEP: Make anonymous class members default to private instead of internal, #715 #1061

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Make anonymous class members default to private instead of internal

Fixes #715

Description

See #715 for info and rationale. This makes "AnonymousClass" implementation members private instead of internal where possible (and readonly, where possible). This also takes the opportunity to remove redundant constructors and unused "outerInstance" fields where applicable.

@paulirwin paulirwin added the notes:improvement An enhancement to an existing feature label Dec 6, 2024
@paulirwin paulirwin requested a review from NightOwl888 December 6, 2024 05:39
@NightOwl888 NightOwl888 self-requested a review December 14, 2024 12:39
@paulirwin paulirwin merged commit f7038ba into apache:master Dec 15, 2024
199 checks passed
@paulirwin paulirwin deleted the issue/715 branch December 15, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:improvement An enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All methods, fields, and properties should be marked private instead of internal in all anonymous classes
2 participants