LUCENE-10417: Revert "LUCENE-10315" #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2022 15:09
… ForUtil (apache#541)" This reverts commit 8c67a38.
jpountz
approved these changes
Feb 24, 2022
gf2121
added a commit
to gf2121/lucene
that referenced
this pull request
Feb 24, 2022
gf2121
added a commit
that referenced
this pull request
Feb 24, 2022
wjp719
added a commit
to wjp719/lucene
that referenced
this pull request
Feb 27, 2022
* main: LUCENE-10421: use Constant instead of relying upon timestamp (apache#686) Remove TODO for LUCENE-9952 since that issue was fixed LUCENE-10382: Use `IndexReaderContext#id` to check reader identity. (apache#702) LUCENE-10408: Write doc IDs of KNN vectors as ints rather than vints. (apache#708) LUCENE-10439: Support multi-valued and multiple dimensions for count query in PointRangeQuery (apache#705) LUCENE-10417: Revert "LUCENE-10315" (apache#706) LUCENE-10382: Fix testSearchWithVisitedLimit failures LUCENE-10435: add CHANGES.txt entry (apache#704) LUCENE-10382: Ensure kNN filtering works with other codecs (apache#700) LUCENE-10054: Make sure to use Lucene90 codec in unit tests (apache#699) LUCENE-10435: Break loop early while checking whether DocValuesFieldExistsQuery can be rewrite to MatchAllDocsQuery (apache#701) LUCENE-10437: Improve error message in the Tessellator for polygon with all points collinear (apache#703) LUCENE-10416: move changes entry to v10.0.0
dantuzi
pushed a commit
to SeaseLtd/lucene
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIMD-optimization for BKD
DocIdsWriterwas introduced in #652 in order to speed up decoding of docIDs, but it leads to the regression in nightly benchmark.https://home.apache.org/~mikemccand/lucenebench/IntNRQ.html
I tried to run
wiki10mlocally but can not reproduce the regression. I'll continue to dig, but i think we need to revert it first.