Check ahead if we can get the count #13899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuXugang
force-pushed
the
earlyterminationCout
branch
from
efd0115
to
980f7ea
Compare
jpountz
reviewed
Oct 15, 2024
LuXugang
force-pushed
the
earlyterminationCout
branch
from
980f7ea
to
105e3c2
Compare
Thank you for your feedback! @jpountz I really appreciate your suggestion. I’ve made the changes as you recommended |
jpountz
approved these changes
Oct 24, 2024
| IteratorAndCount itAndCount = getDocIdSetIteratorOrNull(context); | ||
| if (lowerValue > upperValue) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
This could be moved before the check of whether the segment has deletes?
There was a problem hiding this comment.
if lowerValue > upperValue and has deletes, PointRangeQuery's count will reture -1.
I’ll temporarily maintain the consistency of the two queries for now. Later, we can consider whether to add this optimization to the PointRangeQuery. @jpountz
LuXugang
force-pushed
the
earlyterminationCout
branch
from
c0b5a35
to
fa7274a
Compare
LuXugang
added a commit
that referenced
this pull request
Oct 25, 2024
Currently, we traverse the BKD tree or perform a binary search using DocValues first, and then check whether the count can be obtained in the count() method of IndexSortSortedNumericDocValuesRangeQuery. we should consider providing a mechanism to perform this check beforehand, avoid unnecessary processing when dealing with a sparseRange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether the IndexSortSortedNumericDocValuesRangeQuery's count can be obtained before traversing the BKD tree or performing binary search using DocValues.
see #13890