Fix vector scorer interface consistency #13365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucene/core/src/java/org/apache/lucene/util/quantization/QuantizedByteVectorValues.java
Show resolved
Hide resolved
benwtrent
commented
May 13, 2024
| @@ -36,29 +36,6 @@ public FloatVectorSimilarityValuesSource(float[] vector, String fieldName) { | |||
| this.queryVector = vector; | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
This is no longer necessary. I should have removed it in the original vector scorer PR
benwtrent
added a commit
that referenced
this pull request
May 13, 2024
Follow up to: #13181 I noticed the quantized interface had a slightly different name. Additionally, testing showed we are inconsistent when there aren't any vectors to score. This makes the response consistent (e.g. null when there aren't any vectors).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #13181
I noticed the quantized interface had a slightly different name.
Additionally, testing showed we are inconsistent when there aren't any vectors to score. This makes the response consistent (e.g.
nullwhen there aren't any vectors).