require that float vector components are smaller than 1E17 to prevent overflowing to Infinity #12373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents are smaller than 1E17 to prevent overflowing to Infinity
|
cc @uschindler |
benwtrent
reviewed
Jun 21, 2023
| * further to accommodate the addition of multiple such components in similarity computations in | ||
| * vectors up to MAX_DIMENSIONS in length. | ||
| */ | ||
| public static final float MAX_FLOAT32_COMPONENT = 1E17f; |
There was a problem hiding this comment.
squareDistance is very different than dotProduct and enforcing the same limitations on both seems strange.
There was a problem hiding this comment.
that's true, but there's also something to be said for "here's a simple rule to follow" vs "look up the docs on every distance function to see what the limit is"
|
it's not clear that we need this limit and it seems somewhat complicated to maintain. I'm closing since we haven't seen any activity in quite a while and there's no consensus to impose this limit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to PR #12281