Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move max recursion from Operations.java to AutomatonTestUtil.java #12298

Merged
merged 1 commit into from
May 16, 2023
Merged

move max recursion from Operations.java to AutomatonTestUtil.java #12298

merged 1 commit into from
May 16, 2023

Conversation

tang-hi
Copy link
Contributor

@tang-hi tang-hi commented May 16, 2023

Description

move max recursion from Operations.java to AutomatonTestUtil.java according to @rmuir 's comment in #12286

rmuir
rmuir approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@rmuir rmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning out the last remaining recursive function in here

@rmuir rmuir merged commit f53eb28 into apache:main May 16, 2023
@rmuir
Copy link
Member

rmuir commented May 16, 2023

The limit can only be removed in main branch as there are still some recursive algorithms in branch_9x. More invasive/heavier automaton changes have happened in 10.x, I think it is ok, we are still moving forwards.

@tang-hi
Copy link
Contributor Author

tang-hi commented May 16, 2023

thanks @rmuir

@mikemccand
Copy link
Member

Thank you @tang-hi!

@mikemccand mikemccand added this to the 10.0.0 milestone May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmuir rmuir rmuir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tang-hi @rmuir @mikemccand