Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban use of Math.fma across the entire codebase #12014

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Ban use of Math.fma across the entire codebase #12014

merged 1 commit into from
Dec 17, 2022

Commits on Dec 13, 2022

  1. Ban use of Math.fma across the entire codebase 

    When FMA is not supported by the hardware, these methods fall back to
BigDecimal usage which causes them to be 2500x slower.

While most hardware in the last 10 years may have the support, out of
box both VirtualBox and QEMU don't pass thru FMA support (for the latter
at least you can tweak it with e.g. -cpu host or similar to fix this).

This creates a terrible undocumented performance trap. Prevent it from
sneaking into our codebase.
    @rmuir
    rmuir committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    da07738 View commit details
    Browse the repository at this point in the history