-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce MultiprocessRollingFileAppender overhead #443
Reduce MultiprocessRollingFileAppender overhead #443
Conversation
The benchmarks on Windows 11 Visual Studio 2022 are:
|
This PR onlly reduced the overhead by about 4% on Ubuntu gcc. Note that the benchmarks set BufferedIO=true |
To improve performance on Windows, it would be necessary to use ReadDirectoryChangesW with a Seems a bit too much code to add given the level of usage of the appender. |
The benchmark on Ubuntu 22.04 gcc 11.4 are