Kill yarn app when executing statement cause beeline hang #647
Comments
3 tasks
yaooqinn
pushed a commit
that referenced
this issue
May 26, 2021
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/NetEase/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> When ExecuteStatement running in async, if engine broken(e.g. killed by yarn), the thread just crash without `setOperationException(ke)`, then client(like `beeline`) will hang. Close #647 ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request Manual tested on our yarn cluster: kill yarn app when executing statement. 1. `beeline` connect hiveserver2. Result: exit with error code 2 2. `beeline` connect kyuubi(before this patch). Result: hang 3. `beeline` connect kyuubi(after this patch). Result: exit with error code 2 Closes #646 from pan3793/async-hang. Closes #647 418fca9 [Cheng Pan] move engine crash test to KyuubiOperationPerConnectionSuite 03e5d73 [Cheng Pan] simplify ut 1651991 [Cheng Pan] tune test name 392dd03 [Cheng Pan] ut 728c040 [Cheng Pan] address comments 8031528 [Cheng Pan] Capture exceptions in async ExecuteStatement Authored-by: Cheng Pan <379377944@qq.com> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit 8ce6d01) Signed-off-by: Kent Yao <yao@apache.org>
pan3793
added a commit
to pan3793/kyuubi
that referenced
this issue
May 27, 2021
3 tasks
ulysses-you
pushed a commit
that referenced
this issue
May 27, 2021
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/NetEase/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request Closes #648 from pan3793/followup. Closes #648 28cd6da [Cheng Pan] [FOLLOWUP #647] Fix flaky test Authored-by: Cheng Pan <379377944@qq.com> Signed-off-by: ulysses-you <ulyssesyou18@gmail.com>
ulysses-you
pushed a commit
that referenced
this issue
May 27, 2021
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/NetEase/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request Closes #648 from pan3793/followup. Closes #648 28cd6da [Cheng Pan] [FOLLOWUP #647] Fix flaky test Authored-by: Cheng Pan <379377944@qq.com> Signed-off-by: ulysses-you <ulyssesyou18@gmail.com> (cherry picked from commit b09c87b) Signed-off-by: ulysses-you <ulyssesyou18@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1. Describe the bug
Kill yarn app when executing statement cause beeline hang
2. Environments
2.1 Versions
Kyuubi
Spark
2.2 Kyuubi Configurations
2.3 Spark Configurations
3. Steps to reproduce
3.1 Operations
beeline3.2 Expected behavior
beeline exit with error code 2. (which hive does)
3.3 Actual behavior
beeline hang
4. Additional context
4.1 Log of the server
4.2 Log of the corresponding engine
The text was updated successfully, but these errors were encountered: