Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4 #1557

Closed
wants to merge 1 commit into from

Conversation

liusheng
Copy link

@liusheng liusheng commented Jan 26, 2021

Proposed changes

A special rocksdbjni version for aarch64 has been released by rocksdb community. [1][2]

This patch bumps the rocksdbjni version to 5.18.4 to make the Storm can be built in aarch64.

[1] https://github.com/facebook/rocksdb/releases/tag/v5.18.4
[2] facebook/rocksdb#6250

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

This change Bump the rocksdbjni dependency version to 5.18.4 to support ARM64 platform.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6828

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 27.954%

Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java 2 76.32%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 6729: -0.005%
Covered Lines: 26254
Relevant Lines: 93918

💛 - Coveralls

@liusheng
Copy link
Author

liusheng commented Feb 3, 2021

Hi @hit-lacus @zzcclp Could you please take a look this PR ? Thanks a lot!

@hit-lacus hit-lacus added the Work In Progress This patch is incomplete, maybe author need update this patch ? label Feb 7, 2021
@liusheng
Copy link
Author

Hi, could anyone can help to review this PR ?

@liusheng
Copy link
Author

liusheng commented Mar 5, 2021

Hi @hit-lacus
Could you please help to take a look this ?

@liusheng
Copy link
Author

merged changes of this pr to #1558

@liusheng liusheng closed this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work In Progress This patch is incomplete, maybe author need update this patch ?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants