feat: Enable to save slowlog in logfile #2823
Conversation
greatsharp
changed the title
|
It's a good idea, thanks! |
src/stats/log_collector.cc
Outdated
| // json format | ||
| auto log = fmt::format("[slowlog] {{\"id\":{}, \"timestamp\":{}, \"duration\":{}, \"cmd\":\"{}\", " | ||
| "\"ip\":\"{}\", \"port\":{}, \"client_name\":\"{}\"}}", | ||
| entry->id, entry->time, entry->duration, cmd, entry->ip, entry->port, entry->client_name); |
There was a problem hiding this comment.
Hmm in other places we don't use JSON format in logs, so maybe we should consider if we want to use JSON format in log here.
There was a problem hiding this comment.
-
just want to show slowlog integrally in log file, distinguish with other runtime logs.
-
if third-party software wants to gather slowlog from log file, json format maybe more friendlly.
There was a problem hiding this comment.
@greatsharp I think it's already distinguished since the lines have the [slowlog] prefix. What @PragmaTwice might suggested was to introduce one more option to specify the slow log format (for example, "text" (default) or "json"). WDYT, @PragmaTwice ?
|
No description provided.