fix(tls): remove SSL_sendfile path to avoid errors in replication fullsync #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
PragmaTwice
changed the title
git-hulk
approved these changes
Feb 1, 2025
torwig
approved these changes
Feb 1, 2025
|
rizkymma
pushed a commit
to rizkymma/kvrocks
that referenced
this pull request
Feb 4, 2025
PragmaTwice
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #2756 .
It seems that
SockSendFileImpl<SSL_sendfile>cannot work well, and it can recover to normal if we useSockSendFileImpl<SendFileSSLImpl>, reproduced on my local.The core changes are in
src/common/io_util.cc.