KAFKA-18613: Improve test coverage for missing topics #19189
+3,506
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic streams group heartbeat handling. - No support for static membership - No support for configurations (using constants instead) - No support for regular expressions
Tests for joining with missing source topics, internal topics, incorrectly partitioned topics, and stale topologies.
|
@cadonna Could you have a look? I'm adding three tests as a separate PR. |
lucasbru
commented
Mar 12, 2025
| @@ -180,17 +178,13 @@ private static void enforceCopartitioning(final StreamsTopology topology, | |||
| x.repartitionSourceTopics().stream().filter(y -> y.partitions() == 0) | |||
| ).map(StreamsGroupTopologyValue.TopicInfo::name).collect(Collectors.toSet()); | |||
|
|
|||
| if (fixedRepartitionTopics.isEmpty() && flexibleRepartitionTopics.isEmpty()) { | |||
| log.info("Skipping the repartition topic validation since there are no repartition topics."); | |||
There was a problem hiding this comment.
Skipping here is actually not correct - we need to enforce copartitioning also for source topics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for joining with missing source topics,
internal topics, incorrectly partitioned topics,
and stale topologies.
This is a stacked PR. Only review commits starting from "KAFKA-18613: Improve test coverage for missing topics"