KAFKA-17457 Don't allow ZK migration to start without transactions #17094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccabe
reviewed
Sep 4, 2024
|
@cmccabe I think the remaining test failures are unrelated 
|
mumrah
added a commit
to mumrah/kafka
that referenced
this pull request
Sep 6, 2024
…pache#17094) This patch raises the minimum MetadataVersion for migrations to 3.6-IV1 (metadata transactions). This is only enforced on the controller during bootstrap (when the log is empty). If the log is not empty on controller startup, as in the case of a software upgrade, we allow the migration to continue where it left off. The broker will log an ERROR message if migrations are enabled and the IBP is not at least 3.6-IV1. Reviewers: Colin P. McCabe <cmccabe@apache.org>
mumrah
added a commit
to mumrah/kafka
that referenced
this pull request
Sep 6, 2024
…pache#17094) This patch raises the minimum MetadataVersion for migrations to 3.6-IV1 (metadata transactions). This is only enforced on the controller during bootstrap (when the log is empty). If the log is not empty on controller startup, as in the case of a software upgrade, we allow the migration to continue where it left off. The broker will log an ERROR message if migrations are enabled and the IBP is not at least 3.6-IV1. Reviewers: Colin P. McCabe <cmccabe@apache.org>
cmccabe
pushed a commit
that referenced
this pull request
Sep 7, 2024
…17094) (#17119) This patch raises the minimum MetadataVersion for migrations to 3.6-IV1 (metadata transactions). This is only enforced on the controller during bootstrap (when the log is empty). If the log is not empty on controller startup, as in the case of a software upgrade, we allow the migration to continue where it left off. The broker will log an ERROR message if migrations are enabled and the IBP is not at least 3.6-IV1. Reviewers: Colin P. McCabe <cmccabe@apache.org>
cmccabe
pushed a commit
that referenced
this pull request
Sep 7, 2024
…17094) (#17120) This patch raises the minimum MetadataVersion for migrations to 3.6-IV1 (metadata transactions). This is only enforced on the controller during bootstrap (when the log is empty). If the log is not empty on controller startup, as in the case of a software upgrade, we allow the migration to continue where it left off. The broker will log an ERROR message if migrations are enabled and the IBP is not at least 3.6-IV1. Reviewers: Colin P. McCabe <cmccabe@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.9 is our last 3.x release, it is a likely version for users to be on when doing ZK to KRaft migrations. Since we have made many fixes since the initial preview of migrations in 3.4, we should ensure that users cannot start a migration without certain improvements. Specifically, we do not want any users attempting migrations without the support of KIP-868 Metadata Transactions.
This patch prevents the controller from activating if the log is empty, migrations are enabled, and the bootstrap metadata version does not support transactions.
If the log is not empty on startup, as in the case of a software upgrade, we allow the migration to continue where it left off.