Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17277: [2/2] Add feature dependency command to the storage and the feature command tool #17093

Conversation

rreddy-22
Copy link
Contributor

This patch belongs to the ongoing efforts of implementing KIP-1022.

Added feature-dependencies command to look up dependencies for a given feature version supplied by --feature flag. If the feature is not known or the version not yet defined, we throw an error.

Examples :
bin/kafka-feature feature-dependencies --feature transaction.version=2
transaction.version=2 requires:
metadata.version=4 (3.3-IV0) (listing any other version dependencies)

bin/kafka-feature feature-dependencies --feature metadata.version=17
metadata.version=17 (3.7-IV2) has no dependencies

@github-actions github-actions bot added core Kafka Broker tools labels Sep 23, 2024
@jolshan
Copy link
Contributor

jolshan commented Sep 24, 2024

Can we fix:


* What went wrong:
--
  | 3191 | 01:34:51 PM | Execution failed for task ':tools:spotlessJavaCheck'.
  | 3192 | 01:34:51 PM | > The following files had format violations:
  | 3193 | 01:34:51 PM | src/main/java/org/apache/kafka/tools/FeatureCommand.java
  | 3194 | 01:34:51 PM | @@ -40,11 +40,11 @@
  | 3195 | 01:34:51 PM | import·net.sourceforge.argparse4j.internal.HelpScreenException;
  | 3196 | 01:34:51 PM |  
  | 3197 | 01:34:51 PM | import·java.util.Arrays;
  | 3198 | 01:34:51 PM | +import·java.util.HashMap;
  | 3199 | 01:34:51 PM | import·java.util.List;
  | 3200 | 01:34:51 PM | +import·java.util.Map;
  | 3201 | 01:34:51 PM | import·java.util.Optional;
  | 3202 | 01:34:51 PM | import·java.util.Properties;
  | 3203 | 01:34:51 PM | -import·java.util.Map;
  | 3204 | 01:34:51 PM | -import·java.util.HashMap;
  | 3205 | 01:34:51 PM | import·java.util.TreeMap;
  | 3206 | 01:34:51 PM | import·java.util.concurrent.ExecutionException;
  | 3207 | 01:34:51 PM | import·java.util.stream.Collectors;
  | 3208 | 01:34:51 PM | Run './gradlew :tools:spotlessApply' to fix these violations.


@jolshan
Copy link
Contributor

jolshan commented Sep 26, 2024

Still seeing an issue with Scala 2.12 :(

@jolshan
Copy link
Contributor

jolshan commented Sep 26, 2024

Discussed on https://issues.apache.org/jira/browse/KAFKA-17617 that we will remove java 8 and Scala 2.12 anyway so I will merge.

@jolshan jolshan merged commit 6cb70a8 into apache:trunk Sep 26, 2024
9 of 10 checks passed
@jolshan jolshan deleted the rreddy/KAFKA-17277-Pt2-Add-feature-dependencies-to-tools branch September 26, 2024 22:44
bbejeck pushed a commit to bbejeck/kafka that referenced this pull request Sep 28, 2024
…the feature command tool (apache#17093)

This patch belongs to the ongoing efforts of implementing KIP-1022.

Added feature-dependencies command to look up dependencies for a given feature version supplied by --feature flag. If the feature is not known or the version not yet defined, we throw an error.

Examples :
bin/kafka-feature feature-dependencies --feature transaction.version=2
transaction.version=2 requires:
metadata.version=4 (3.3-IV0) (listing any other version dependencies)

bin/kafka-feature feature-dependencies --feature metadata.version=17
metadata.version=17 (3.7-IV2) has no dependencies

Reviewers: Justine Olshan <jolshan@confluent.io>, Artem Livshits <alivshits@confluent.io>
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Sep 30, 2024
…the feature command tool (apache#17093)

This patch belongs to the ongoing efforts of implementing KIP-1022.

Added feature-dependencies command to look up dependencies for a given feature version supplied by --feature flag. If the feature is not known or the version not yet defined, we throw an error.

Examples :
bin/kafka-feature feature-dependencies --feature transaction.version=2
transaction.version=2 requires:
metadata.version=4 (3.3-IV0) (listing any other version dependencies)

bin/kafka-feature feature-dependencies --feature metadata.version=17
metadata.version=17 (3.7-IV2) has no dependencies

Reviewers: Justine Olshan <jolshan@confluent.io>, Artem Livshits <alivshits@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Kafka Broker tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants