-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-17277: [2/2] Add feature dependency command to the storage and the feature command tool #17093
Merged
jolshan
merged 11 commits into
apache:trunk
from
confluentinc:rreddy/KAFKA-17277-Pt2-Add-feature-dependencies-to-tools
Sep 26, 2024
Merged
KAFKA-17277: [2/2] Add feature dependency command to the storage and the feature command tool #17093
jolshan
merged 11 commits into
apache:trunk
from
confluentinc:rreddy/KAFKA-17277-Pt2-Add-feature-dependencies-to-tools
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolshan
reviewed
Sep 9, 2024
jolshan
reviewed
Sep 9, 2024
jolshan
reviewed
Sep 13, 2024
jolshan
reviewed
Sep 13, 2024
MINOR: Address comments for 17093
Can we fix:
|
jolshan
approved these changes
Sep 25, 2024
Still seeing an issue with Scala 2.12 :( |
Discussed on https://issues.apache.org/jira/browse/KAFKA-17617 that we will remove java 8 and Scala 2.12 anyway so I will merge. |
jolshan
deleted the
rreddy/KAFKA-17277-Pt2-Add-feature-dependencies-to-tools
branch
September 26, 2024 22:44
bbejeck
pushed a commit
to bbejeck/kafka
that referenced
this pull request
Sep 28, 2024
…the feature command tool (apache#17093) This patch belongs to the ongoing efforts of implementing KIP-1022. Added feature-dependencies command to look up dependencies for a given feature version supplied by --feature flag. If the feature is not known or the version not yet defined, we throw an error. Examples : bin/kafka-feature feature-dependencies --feature transaction.version=2 transaction.version=2 requires: metadata.version=4 (3.3-IV0) (listing any other version dependencies) bin/kafka-feature feature-dependencies --feature metadata.version=17 metadata.version=17 (3.7-IV2) has no dependencies Reviewers: Justine Olshan <jolshan@confluent.io>, Artem Livshits <alivshits@confluent.io>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Sep 30, 2024
…the feature command tool (apache#17093) This patch belongs to the ongoing efforts of implementing KIP-1022. Added feature-dependencies command to look up dependencies for a given feature version supplied by --feature flag. If the feature is not known or the version not yet defined, we throw an error. Examples : bin/kafka-feature feature-dependencies --feature transaction.version=2 transaction.version=2 requires: metadata.version=4 (3.3-IV0) (listing any other version dependencies) bin/kafka-feature feature-dependencies --feature metadata.version=17 metadata.version=17 (3.7-IV2) has no dependencies Reviewers: Justine Olshan <jolshan@confluent.io>, Artem Livshits <alivshits@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch belongs to the ongoing efforts of implementing KIP-1022.
Added feature-dependencies command to look up dependencies for a given feature version supplied by --feature flag. If the feature is not known or the version not yet defined, we throw an error.
Examples :
bin/kafka-feature feature-dependencies --feature transaction.version=2
transaction.version=2 requires:
metadata.version=4 (3.3-IV0) (listing any other version dependencies)
bin/kafka-feature feature-dependencies --feature metadata.version=17
metadata.version=17 (3.7-IV2) has no dependencies