MINOR: Fix typo and refactor new group coordinator tests #17072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the tests for fetchOffsets and fetchAllOffsets together into parameterized tests since they share the same structure.
m1a2st
reviewed
Sep 2, 2024
| @@ -1140,20 +1154,22 @@ public void testFetchOffsets( | |||
|
|
|||
| if (requireStable) { | |||
| when(runtime.scheduleWriteOperation( | |||
| ArgumentMatchers.eq("fetch-offsets"), | |||
| ArgumentMatchers.eq(fetchAllOffsets ? "fetch-all-offsets" : "fetch-offsets"), | |||
| ArgumentMatchers.eq(new TopicPartition("__consumer_offsets", 0)), | |||
There was a problem hiding this comment.
I think __consumer_offsets can replace by Topic.GROUP_METADATA_TOPIC_NAME, use constant is better than string
There was a problem hiding this comment.
__consumer_offsets is used throughout the new group coordinator tests. I think it makes sense to update all instances in the new group coordinator at once and pushed an update for it.
| ArgumentMatchers.eq(new TopicPartition("__consumer_offsets", 0)), | ||
| ArgumentMatchers.eq(Duration.ofMillis(5000)), | ||
| ArgumentMatchers.any() | ||
| )).thenReturn(CompletableFuture.completedFuture(response)); | ||
| } else { | ||
| when(runtime.scheduleReadOperation( | ||
| ArgumentMatchers.eq("fetch-offsets"), | ||
| ArgumentMatchers.eq(fetchAllOffsets ? "fetch-all-offsets" : "fetch-offsets"), | ||
| ArgumentMatchers.eq(new TopicPartition("__consumer_offsets", 0)), |
| when(runtime.scheduleWriteOperation( | ||
| ArgumentMatchers.eq("fetch-all-offsets"), | ||
| ArgumentMatchers.eq(fetchAllOffsets ? "fetch-all-offsets" : "fetch-offsets"), | ||
| ArgumentMatchers.eq(new TopicPartition("__consumer_offsets", 0)), |
squah-confluent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parameterized tests since they share the same structure.
new group coordinator tests.
Committer Checklist (excluded from commit message)