KAFKA-17137: Ensure Admin APIs are properly tested (part 0) #16676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYang0529
force-pushed
the
KAFKA-17137
branch
from
b4030f7
to
c7a9b08
Compare
|
@FrankYang0529 Could you please rebase code? |
FrankYang0529
force-pushed
the
KAFKA-17137
branch
2 times, most recently
from
ab2b6c4
to
02e553e
Compare
chia7712
reviewed
Sep 5, 2024
| @ParameterizedTest | ||
| @ValueSource(strings = Array("zk", "kraft")) | ||
| def testDeleteTopicsWithOptionTimeoutMs(quorum: String): Unit = { | ||
| client = createAdminClient |
There was a problem hiding this comment.
Please use createInvalidAdminClient. Otherwise, the request could be sent out even though the timeout = 0
There was a problem hiding this comment.
Thanks for the suggestion. Updated it.
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
KAFKA-17137
branch
from
02e553e
to
8ef05a4
Compare
chia7712
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)