Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Disable JDK 11 and 17 tests on PRs #16051

Merged
merged 5 commits into from
May 28, 2024
Merged

MINOR: Disable JDK 11 and 17 tests on PRs #16051

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1e5cca
MINOR: Disable JDK 11 and 17 builds on PRs
gharris1727 May 23, 2024
ac7bb77
fixup: wrong syntax for conditions
gharris1727 May 23, 2024
59c6662
fixup: how do i test jenkinsfiles locally?
gharris1727 May 23, 2024
9b1e670
fixup: compile on 11 and 17, but don't run tests
gharris1727 May 23, 2024
2fa9bdb
fixup: invert condition
gharris1727 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ def doTest(env, target = "test") {
junit '**/build/test-results/**/TEST-*.xml'
}

def runTestOnDevBranch(env) {
if (!isChangeRequest(env)) {
doTest(env)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they don't run on PRs, I don't think anyone will validate the results for the branch builders. We should probably remove Java 11 and 17 altogether now that we have ported most tests to run with Java 16 and higher (previously many were excluded).

I had suggested this in an internal conversation, so good to see similar action here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about leaving the 11 and 17 branch builders as-is until 4.0? This will need some rework then to effect the KIPs that are changing the minimum version requirements and having different minimums for the different modules. We can figure out a strategy for branch & pr builds then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the value - once we drop support for Java 8, we will simply change the Java 8 builder to Java 11. Am I missing something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes - we'll also have to configure the brokers, etc. to use Java 17. In any case, I think whatever we have to do there won't be any harder if we just delete the Java 11 and 17 builders for now. And it will make the 3.8 builds lighter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to sign up future release managers for additional verification of the 11 and 17 builds that the CI has been doing for previous releases. I don't expect any failures to be introduced that affect 11 and 17 but not 8 or 21, but I would rather find those failures out in CI after merge than during the RC generation stage.

And for selfish reasons, I also would like to continue seeing the 11 and 17 trunk results published so I can do flaky test analysis. With this patch as-is, we're keeping the same number of test runs on trunk, but if we removed these entirely we would be cutting those in half. I don't pay attention to the PR builds for statistics because contributors may have bad patches applied that aren't worth investigating.


def doStreamsArchetype() {
echo 'Verify that Kafka Streams archetype compiles'

Expand Down Expand Up @@ -132,7 +138,7 @@ pipeline {
}
steps {
doValidation()
doTest(env)
runTestOnDevBranch(env)
echo 'Skipping Kafka Streams archetype test for Java 11'
}
}
Expand All @@ -151,7 +157,7 @@ pipeline {
}
steps {
doValidation()
doTest(env)
runTestOnDevBranch(env)
echo 'Skipping Kafka Streams archetype test for Java 17'
}
}
Expand Down