Resolve minimatch version conflict in wro4j-maven-plugin dependencies. #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturobernalg
force-pushed
the
feature/dependency
branch
from
fb4900c to
e199cfc
Compare
juanpablo-santos
requested changes
Jun 15, 2023
| @@ -722,6 +722,12 @@ | |||
| <groupId>org.mockito</groupId> | |||
| <artifactId>mockito-core</artifactId> | |||
| <version>${mockito.version}</version> | |||
| <exclusions> | |||
There was a problem hiding this comment.
Hi @arturobernalg!
please also revert commit 354ba9c and apply it here, so we can test with the new plugin that:
- it still performs its tasks (files are minified, merged etc.)
- mvn dependency:go-offline ends ok (it was the part failing on the Docker build)
There was a problem hiding this comment.
mmm
With version 1.9.0, there's no need to exclude any libraries. I'll continue working on fixing the build with version 1.10.1.
mitreid-connect/OpenID-Connect-Java-Spring-Server#1575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.