Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Prone code style verification #632

Merged
merged 40 commits into from
Oct 31, 2020
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
5ae71f6
Add Error Prone code style verification
vlsi Oct 18, 2020
43217ec
Remove LoggingManager class (it has been deprecated since JMeter 3.2)
vlsi Oct 18, 2020
797f9e4
Use UTF-8 encoding in BeanShellClient instead of platform-specific one
vlsi Oct 18, 2020
f6b1bfa
Add JavaDoc summaries to RandomVariableConfig, CounterConfig, JavaSam…
vlsi Oct 18, 2020
f5e3d7a
Suppress error-prone errors for junit-sample
vlsi Oct 18, 2020
ba94b52
Replace obsolete Vector and Hashtable with ArrayList and HashMap
vlsi Oct 18, 2020
b3b2eec
Replace LinkedList with ArrayList
vlsi Oct 18, 2020
db768c0
Remove uses of deprecated APIs
vlsi Oct 18, 2020
77d5d1b
Remove excessive parenthesis
vlsi Oct 18, 2020
73b925c
Avoid unsafe reflection cast
vlsi Oct 18, 2020
f5c64e1
Avoid use of Enumeration in ClassFinder
vlsi Oct 18, 2020
e8fbfa7
Fixup JavaDocs
vlsi Oct 18, 2020
9c92e99
Make constructors of abstract classes protected rather than public
vlsi Oct 18, 2020
7e42131
Avoid import Map.Entry to avoid amboguity
vlsi Oct 18, 2020
93e27d7
Use lower-case field names for non-static fields in StatCalculator
vlsi Oct 18, 2020
dc4bdc0
Make enums immutable
vlsi Oct 18, 2020
63d791c
Suppresss MissingSummary and EmptyBlockTag for now
vlsi Oct 18, 2020
599fcc9
Suppress deprecation warnings for TestResultAction
vlsi Oct 18, 2020
2fde32b
Suppress deprecation warnings in SamplerMetricFixedModeTest
vlsi Oct 18, 2020
80c3914
Suppress DefaultCharset usage: either suppress the warning or use a c…
vlsi Oct 18, 2020
e78352a
Fix InconsistentCapitalization warnings
vlsi Oct 18, 2020
369f651
Suppress JdkObsolete warnings for Enumeration
vlsi Oct 18, 2020
deb89ba
Remove unused variables
vlsi Oct 18, 2020
3d133a8
Suppress JdkObsolete warnings for usages of Date
vlsi Oct 18, 2020
5f84f1e
Add missing @Override annotations
vlsi Oct 18, 2020
b1255aa
Mark empty catch blocks with a comment
vlsi Oct 18, 2020
d756670
Suppress FutureReturnValueIgnored
vlsi Oct 18, 2020
bb34632
Suppress Thread.yield usage
vlsi Oct 18, 2020
c441e5b
Suppress JavaTimeDefaultTimeZone
vlsi Oct 18, 2020
ac19a29
Inline format specifiers when they are used only once
vlsi Oct 18, 2020
ecf72b7
Resolve MixedMutabilityReturnType: make the returned lists unmodifiable
vlsi Oct 18, 2020
8f5ca8d
Suppress UnnecessaryAnonymousClass as the only two warnings seem to b…
vlsi Oct 18, 2020
8ae3458
Resolve SynchronizeOnNonFinalField
vlsi Oct 18, 2020
9d7b694
Suppress warnings for Hashtable usage when the class is required for …
vlsi Oct 18, 2020
a4c1ab8
Move .lock() statements out of try to avoid accidetal release if lock…
vlsi Oct 18, 2020
ee0aead
Suppress StaticAssignmentInConstructor in Summarizer
vlsi Oct 18, 2020
7e2a47d
Suppress JdkObsolete when using appendReplacement(StringBuffer,...)
vlsi Oct 18, 2020
5fad27c
Suppress JavaLangClash for ThreadGroup
vlsi Oct 18, 2020
ebe65b8
Avoid NarrowingCompoundAssignment warning
vlsi Oct 18, 2020
150a275
Make members of final classes package-private
vlsi Oct 18, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Suppress StaticAssignmentInConstructor in Summarizer
vlsi committed Oct 31, 2020
commit ee0aead60c528147f51eeff784e61cbadfc22641
Original file line number Diff line number Diff line change
@@ -121,8 +121,9 @@ public class Summariser extends AbstractTestElement
* Called several times during test startup.
* The name will not necessarily have been set at this point.
*/
@SuppressWarnings("StaticAssignmentInConstructor")
public Summariser() {
super();
// TODO: is it needed to reset static field instanceCount in the instance constructor?
synchronized (LOCK) {
ACCUMULATORS.clear();
instanceCount=0;