Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of the third-party jars that are included to the release #620

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Sep 15, 2020

The validation skips JMeter jars, and it helps to spot accidental third-party
dependency addition or removal

Sample failure:

* What went wrong:
Execution failed for task ':src:dist:verifyReleaseDependencies'.
> External dependencies differ (you could update src/dist/src/dist/expected_release_jars.csv if you add -PupdateExpectedJars):
    56938605 => 55421535 bytes (-1517070 bytes)
    97 => 98 files (+1)

  +  137455 groovy-jmx-3.0.5.jar
  - 2137455 groovy-sql-3.0.5.jar
  - 1106993 jna-5.0.0.jar
  + 1506993 jna-5.5.0.jar

@vlsi
Copy link
Collaborator Author

vlsi commented Sep 15, 2020

@pmouawad , @FSchumacher , it might make dependency updates slightly more complicated, however, I think it would prevent us from adding unexpected dependencies. WDYT?

The validation skips JMeter jars, and it helps to spot accidental third-party
dependency addition or removal
@vlsi vlsi merged commit 3dbd8c6 into apache:master Sep 17, 2020
@FSchumacher
Copy link
Contributor

Sorry for the late reply. I think it will help us to understand our dependencies even better. So, thanks for implementing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants