GH-2787: Deadlock in JenaSystem.init() #2792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I set this PR to "draft" - hope you don't mind. |
- Added a fail-fast mechanism: now throwing an `ExceptionInInitializerError` when a thread attempts to enter `JenaSystem.init()` while another thread is in the initialization process. - Refactored `JenaSystem.init()` using the "Initialization-on-demand holder idiom" for simpler and safer initialization. - Implemented integration tests for `JenaSystem.init()`, including parallel execution cases to ensure thread safety.
arne-bdt
force-pushed
the
GH-2787-Deadlock_in_Jena_System_init
branch
from
482bbd1 to
d5f000a
Compare
|
I found another "solution": Added a fail-fast mechanism: now throwing an ExceptionInInitializerError when a thread attempts to enter JenaSystem.init() while another thread is in the initialization process. What do you think? |
|
I think requiring single threaded initialization will break existing usage. Until we agree that it is the only option, I don't think we should go that way. Discussion on the issue. |
|
see #2787 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a fail-fast mechanism: now throwing an
ExceptionInInitializerErrorwhen a thread attempts to enterJenaSystem.init()while another thread is in the initialization process.Refactored
JenaSystem.init()using the "Initialization-on-demand holder idiom" for simpler and safer initialization.Additionally, I have added integration tests for
JenaSystem.init(), including the parallel execution scenario from the issue, to ensure coverage of potential concurrency issues.GitHub issue resolved #2787
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.