OAK-11112 : replaced Maps.newHashMapWithExpectedSize() with new HashM…

[rishabhdaim]

…ap<>(initialCapacity)

[reschke]

I believe for the size calculation we should java common utility method, or even implement newHash* directly in CollectionUtils. @nfsantos ?

[reschke]

why do we need this?

[rishabhdaim]

This is the maximum capacity of hashmap. Any value above this would be reverted to this value.

Also, we might hit negative values if we don't specify an upper limit.

See test below:

@Test public void ensureCapacityWithMaxValue() { int capacity = CollectionUtils.ensureCapacity(1908874369); }

it returns -2147483648, which is wrong.

[reschke]

and maybe also add a comment with a short explanation?

[reschke]

Could you please separate the changes for CollectionUtils from the cases where we use them?

[rishabhdaim]

@reschke Created #1722 for ensureCapacity method changes.

[mbaedke]

If we don't care that the maps will resize, it looks fine. Otherwise we might want to increase the initial capacity.

[rishabhdaim]

@mbaedke we are using CollectionUtils.newHashMap API which creates a hashmap with the expected size to accommodate the expected number of elements without resizing.

[mbaedke]

@mbaedke we are using CollectionUtils.newHashMap API which creates a hashmap with the expected size to accommodate the expected number of elements without resizing.

Yes, of course. I was confused, sorry for the noise.