Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAK-11072: (fix) flaky test: ElasticReliabilityTest.connectionCutOnQuery #1710

Merged
merged 2 commits into from
Sep 12, 2024
Merged

OAK-11072: (fix) flaky test: ElasticReliabilityTest.connectionCutOnQuery #1710

merged 2 commits into from
Sep 12, 2024

Conversation

fabriziofortino
Copy link
Contributor

No description provided.

@steffenvan
Copy link
Contributor

Just out of curiosity, why were the tests flaky?

@fabriziofortino
Copy link
Contributor Author

fabriziofortino commented Sep 12, 2024 •
edited
Loading

@steffenvan the index selection is based on IndexStatistics. For Elasticsearch we need to cache the stats to reduce the number of roundtrips. Because of that, the selection of the right index might take some time once the connection is re-established. The fix reduces the cache refresh time and wraps the assertions in eventually blocks.

@fabriziofortino fabriziofortino merged commit 58bde0a into apache:trunk Sep 12, 2024
1 of 2 checks passed
@fabriziofortino fabriziofortino deleted the OAK-11072 branch September 12, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfsantos nfsantos nfsantos approved these changes

@thomasmueller thomasmueller Awaiting requested review from thomasmueller

@nit0906 nit0906 Awaiting requested review from nit0906

@amit-jain amit-jain Awaiting requested review from amit-jain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziofortino @steffenvan @nfsantos