Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-10670: add support for service principal in oak-upgrade #1329

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

t-rana
Copy link
Contributor

@t-rana t-rana commented Feb 27, 2024

Azure Service Principal Support in oak-segment-azure. Goal is to allow Azure authentication via:

clientId - Id of the Service Principal object / App registered with the Active Directory.
clientSecret - Application password.
tenantId - Azure Active Directory Id.


@Override
public void close() {
if (tmpDir != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe do this after the file store is closed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done

@smiroslav
Copy link
Contributor

@t-rana for new files please add license headers


[INFO] BUILD FAILURE

[INFO] ------------------------------------------------------------------------

[INFO] Total time:  53.227 s (Wall Clock)

[INFO] Finished at: 2024-02-27T09:27:19Z

[INFO] ------------------------------------------------------------------------

[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.15:check (default) on project oak-upgrade: Too many files with unapproved license: 3 See RAT report in: /home/jenkins/jenkins-agent/workspace/Jackrabbit_oak-trunk-pr_PR-1329/oak-upgrade/target/rat.txt -> [Help 1]

[ERROR] 

[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.

[ERROR] Re-run Maven using the -X switch to enable full debug logging.

[ERROR] 

@smiroslav smiroslav merged commit 8f97e2a into apache:trunk Mar 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants