Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load: Trigger last flush time map & tsfile resource degrading after successful load #12024

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

SteveYurongSu
Copy link
Member

@SteveYurongSu SteveYurongSu commented Feb 5, 2024

Description

After loading about 1_200_000 files into the storage engine, the system threw OOM exception.

After careful check, it was found that the current load tsfile operation does not trigger the last flush time map & tsfile resource degrading.

img_v3_027l_1a6ddaed-b927-49f5-a7bb-8274715e9f4g

img_v3_027o_b8422e4d-ea51-424d-b01f-4e3cfecec0eg

image

@SteveYurongSu SteveYurongSu self-assigned this Feb 5, 2024
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (8c90117) 49.16% compared to head (9a6563d) 49.16%.

Files Patch % Lines
.../iotdb/db/storageengine/dataregion/DataRegion.java 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12024      +/-   ##
============================================
- Coverage     49.16%   49.16%   -0.01%     
+ Complexity    26160    26159       -1     
============================================
  Files          2943     2943              
  Lines        184507   184519      +12     
  Branches      22140    22142       +2     
============================================
+ Hits          90716    90720       +4     
- Misses        93791    93799       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveYurongSu SteveYurongSu merged commit 6943524 into master Feb 5, 2024
36 of 37 checks passed
@SteveYurongSu SteveYurongSu deleted the fix-load-degrade branch February 5, 2024 04:54
HTHou pushed a commit that referenced this pull request Mar 5, 2024
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants