-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Populate table name from the identifier in Iceberg conversion #630
Open
jalpan-randeri
wants to merge
1
commit into
apache:main
Choose a base branch
from
jalpan-randeri:jalpan/bugfix-iceberg-filebased-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Bugfix] Populate table name from the identifier in Iceberg conversion #630
jalpan-randeri
wants to merge
1
commit into
apache:main
from
jalpan-randeri:jalpan/bugfix-iceberg-filebased-name
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergTableManager.java
Outdated
Show resolved
Hide resolved
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java
Show resolved
Hide resolved
xtable-core/src/main/java/org/apache/xtable/iceberg/IcebergConversionSource.java
Outdated
Show resolved
Hide resolved
the-other-tim-brown
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you squash down to a single commit?
What is the problem? While converting the iceberg table to other format such as Hudi, the icerberg source table do not populate the table name. This is due to iceberg table's behavior as it is treated as Hadoop tables. This leads to table identified as table-location, leading to confusing conversation. Solution: This commit handles the conversation logic, when icebege table manager provides HadoopTable, it populate the table name from provided input TableIdentifier. This ensures that source table name is carried over to the transformation. Testing: - Added unit test to cover this scenario. Co-authored-by: Tim Brown <tim.brown126@gmail.com>
c357040
to
828112b
Compare
ashvina
requested changes
Feb 13, 2025
.name( | ||
iceTable.name().contains(iceTable.location()) | ||
? sourceTableConfig.getName() | ||
: iceTable.name()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please confirm if existing tests cases cover both the paths?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
While converting the iceberg table to other format such as Hudi, the icerberg source table do not populate the table name. This is due to iceberg table's behavior as it is treated as Hadoop tables. This leads to table identified as table-location, leading to confusing conversation.
BUG= #494
Brief change log
This commit handles the conversation logic, when icebege table manager provides HadoopTable, it populate the table name from provided input TableIdentifier. This ensures that source table name is carried over to the transformation.
Verify this pull request
Manual Verification