This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[Android] developers could change log level using javascript #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YorkShen
commented
Jun 12, 2019
YorkShen
commented
- Add ConsoleLogModule, developers could change log using javascript. Ref demo http://editor.weex.io/vue/8fb63b977fad1bf816b9a9ad79a43fbd
- Print log to logcat and devtool only if WXEnviroment.sLogLevel is bigger than the log being printed.
- Change WXEnviroment.sLogLevel to INFO under debug apk, change it to WARN otherwise. Before this change WXEnvironment.sApplication was always null when initializing WXEnviroment.sLogLevel, so WXEnviroment.sLogLevel was always debug regardless it's actually debuggable or not.
- Enable LogI no matter it's debuggable or not.
- Change the value of LogLevel.value, which should have no influence.
… using http://editor.weex.io/vue/8fb63b977fad1bf816b9a9ad79a43fbd 1. Add ConsoleLogModule, developers could change log using javascript. 1. Print log to logcat and devtool only if WXEnviroment.sLogLevel is bigger than the log being printed. 1. Change WXEnviroment.sLogLevel to INFO under debug apk, change it to WARN otherwise. Before this change WXEnvironment.sApplication was always null when initializing WXEnviroment.sLogLevel, so WXEnviroment.sLogLevel was always debug regardless it's actually debuggable or not. 1. Enable LogI no matter it's debuggable or not. 1. Change the value of LogLevel.value, which should have no influence.
Generated by 🚫 dangerJS |
Darin726
reviewed
Jun 12, 2019
| case "info": | ||
| logLevelEnum = LogLevel.INFO; | ||
| break; | ||
| case "debug": |
There was a problem hiding this comment.
default会导致logLevelEnum取值为false，最终触发ret.put("status", "failure");
| WXEnvironment.sLogLevel = logLevelEnum; | ||
| ret.put("status", "success"); | ||
| } else { | ||
| ret.put("status", "failure"); |
There was a problem hiding this comment.
这里的 success 和 failue 表示啥意思?
There was a problem hiding this comment.
成功和失败，失败的原因一般是用户传的参数错误
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.