Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

merge code to master #1999

Merged
merged 2 commits into from
Jan 3, 2019
Merged

merge code to master #1999

merged 2 commits into from
Jan 3, 2019

Conversation

alwaysfight
Copy link
Contributor

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@zshshr zshshr self-requested a review January 3, 2019 12:12
@weex-bot
Copy link

weex-bot commented Jan 3, 2019 •
edited
Loading

Fails
🚫 Failed to run assembleDebug task for android.
Messages
📖 android build verification finished.

Generated by 🚫 dangerJS

@zshshr zshshr merged commit eda45b3 into apache:master Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zshshr zshshr zshshr approved these changes

@gubaojian gubaojian Awaiting requested review from gubaojian

@wqyfavor wqyfavor Awaiting requested review from wqyfavor wqyfavor is a code owner

@YorkShen YorkShen Awaiting requested review from YorkShen YorkShen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alwaysfight @weex-bot @zshshr @jianhan-he