Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1778] improvement(dashboard): Dashboard adds the ability to automatically format code. #1779

Merged
merged 5 commits into from
Jun 15, 2024

Conversation

yl09099
Copy link
Contributor

@yl09099 yl09099 commented Jun 12, 2024

What changes were proposed in this pull request?

Introducing the front-end eslint code validation tool and formatting the front-end code.

Why are the changes needed?

Fix: #1778

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existential test.

Copy link

github-actions bot commented Jun 12, 2024

Test Results

 2 434 files  ±0   2 434 suites  ±0   5h 0m 31s ⏱️ -23s
   937 tests ±0     936 ✅ ±0   1 💤 ±0  0 ❌ ±0 
10 857 runs  ±0  10 843 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit 8793a31. ± Comparison against base commit 3d0c91a.

♻️ This comment has been updated with latest results.

@zuston zuston requested a review from xianjingfeng June 13, 2024 01:37
@xianjingfeng
Copy link
Member

Single quotes may be more suitable for front-end developers? @yl09099

@yl09099
Copy link
Contributor Author

yl09099 commented Jun 13, 2024

Single quotes may be more suitable for front-end developers? @yl09099

done. Format the code using the command "npx prettier . --write".

@xianjingfeng
Copy link
Member

Single quotes may be more suitable for front-end developers? @yl09099

done. Format the code using the command "npx prettier . --write".

Could you add a job for checking style in the workflow?

Co-authored-by: xianjingfeng <xianjingfeng666@gmail.com>
@yl09099
Copy link
Contributor Author

yl09099 commented Jun 13, 2024

Single quotes may be more suitable for front-end developers? @yl09099

done. Format the code using the command "npx prettier . --write".

Could you add a job for checking style in the workflow?

Single quotes may be more suitable for front-end developers? @yl09099

done. Format the code using the command "npx prettier . --write".

Could you add a job for checking style in the workflow?

This format check rule is automatically triggered at compile time.

Copy link
Member

@xianjingfeng xianjingfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zuston
Copy link
Member

zuston commented Jun 14, 2024

Single quotes may be more suitable for front-end developers? @yl09099

done. Format the code using the command "npx prettier . --write".

Could you add this format command into the dashboard doc? @yl09099

@jerqi jerqi changed the title [#1778][Improvement] Dashboard adds the ability to automatically format code. [#1778] improvement(dashboard): Dashboard adds the ability to automatically format code. Jun 15, 2024
@jerqi jerqi merged commit 8eff38e into apache:master Jun 15, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Dashboard adds the ability to automatically format code.
4 participants