-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1757] feat(server): Add block number check on getting shuffle result #1758
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c2a1a8f
[#1757] feat(server): Add block number check on getting shuffle result
zuston db0e92c
fix
zuston 9193803
fix
zuston 673652d
fix
zuston 8e8c3d6
fix
zuston b82f3e4
output duplicated blockId number in log
zuston 07d9668
fix
zuston c8ad64d
optimize
zuston 1c7908e
fix
zuston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -506,14 +506,23 @@ public void reportShuffleResult( | |
"appId[" + appId + "], shuffleId[" + shuffleId + "], taskAttemptId[" + taskAttemptId + "]"; | ||
|
||
try { | ||
int expectedBlockCount = partitionToBlockIds.values().stream().mapToInt(x -> x.length).sum(); | ||
LOG.info( | ||
"Report " | ||
+ partitionToBlockIds.size() | ||
+ " blocks as shuffle result for the task of " | ||
+ requestInfo); | ||
shuffleServer | ||
.getShuffleTaskManager() | ||
.addFinishedBlockIds(appId, shuffleId, partitionToBlockIds, bitmapNum); | ||
"Accepted blockIds report for {} blocks across {} partitions as shuffle result for task {}", | ||
expectedBlockCount, | ||
partitionToBlockIds.size(), | ||
request); | ||
int updatedBlockCount = | ||
shuffleServer | ||
.getShuffleTaskManager() | ||
.addFinishedBlockIds(appId, shuffleId, partitionToBlockIds, bitmapNum); | ||
if (expectedBlockCount != updatedBlockCount) { | ||
LOG.warn( | ||
"Existing {} duplicated blockIds on blockId report for appId: {}, shuffleId: {}", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately, we encountered this warn level log these days, it make us stressed. Is there indicate something wrong? Can you explain what rare condition scenario can make updatedBlockCount less than expectedBlockCount? Why there are duplicated blockIds on blockId report? |
||
expectedBlockCount - updatedBlockCount, | ||
appId, | ||
shuffleId); | ||
} | ||
} catch (Exception e) { | ||
status = StatusCode.INTERNAL_ERROR; | ||
msg = "error happened when report shuffle result, check shuffle server for detail"; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log is verbose and fill server log, is there a better way to reduce it or do you think
DEBUG
level can be better?