[#1472][FOLLOWUP] fix(client): Fix IllegalReferenceCountException issues when exceptions happened in clientReadHandler.readShuffleData() #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on issues when exceptions happened in clientReadHandler.readShuffleData()
Test Results2 432 files - 5 2 432 suites - 5 4h 39m 36s ⏱️ - 2m 44s For more details on these failures, see this check. Results for commit fc84871. ± Comparison against base commit 59aa30d. |
jerqi
reviewed
Feb 23, 2024
| @@ -269,6 +269,10 @@ private int read() { | |||
| // because PlatformDependent.freeDirectBuffer can only release the ByteBuffer with cleaner. | |||
| if (sdr != null) { | |||
| sdr.release(); | |||
| // We set sdr to null here to prevent IllegalReferenceCountException that could occur | |||
| // if sdr.release() is called multiple times in the close() method, | |||
| // when an exception is thrown by clientReadHandler.readShuffleData(). | |||
There was a problem hiding this comment.
I can't get why this will trigger the issue. sdr will be reassign in the Line 277.
There was a problem hiding this comment.
when an exception is thrown by clientReadHandler.readShuffleData().
An exception is thrown from line 277. So sdr will not be reassigned successfully.
|
CI is unstable, I don't think the failure is related to this PR. |
zuston
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix IllegalReferenceCountException issues when exceptions happened in clientReadHandler.readShuffleData().
Why are the changes needed?
A follow-up PR for: #1522
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.