Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1462] fix(server): Memory may leak when flushQueue is full #1463

Merged
merged 2 commits into from
Jan 19, 2024
Merged

[#1462] fix(server): Memory may leak when flushQueue is full #1463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f50a1b6
[#1464] fix(server): Memory may leak when flushQueue is full
rickyma Jan 18, 2024
9939137
[#1464] fix(server): Memory may leak when flushQueue is full
rickyma Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions server/src/main/java/org/apache/uniffle/server/DefaultFlushEventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ public DefaultFlushEventHandler(
public void handle(ShuffleDataFlushEvent event) {
if (!flushQueue.offer(event)) {
LOG.error("Flush queue is full, discard event: " + event);
// We need to release the memory when discarding the event
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the metric like ShuffleServerMetrics.counterTotalDroppedEventNum.inc();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

event.doCleanup();
ShuffleServerMetrics.counterTotalDroppedEventNum.inc();
} else {
ShuffleServerMetrics.gaugeEventQueueSize.inc();
}
Expand Down